Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable IOperationNameGenerator implementations #272

Merged
merged 11 commits into from
Jan 8, 2024

Conversation

christianhelle
Copy link
Owner

This pull request introduces new features such as the --skip-default-additional-properties and the --operation-name-generator CLI tool arguments to handle OAS documents with conflicting operation ID's and OAS component/schemas with properties called additionalProperties

It also updates the NSwag IOperationNameGenerator implementation and adds documentation to the Settings class.

This resolves #269

@christianhelle christianhelle changed the title Switch IOperationNameGenerator implementations Configurable IOperationNameGenerator implementations Jan 8, 2024
@christianhelle christianhelle self-assigned this Jan 8, 2024
@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4a3590) 97.41% compared to head (336bba8) 97.46%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   97.41%   97.46%   +0.05%     
==========================================
  Files          60       60              
  Lines        2086     2132      +46     
==========================================
+ Hits         2032     2078      +46     
  Misses         37       37              
  Partials       17       17              
Flag Coverage Δ
unittests 97.46% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle force-pushed the query-and-get-endpoint branch 3 times, most recently from f420c4f to 65dbc78 Compare January 8, 2024 22:19
@christianhelle christianhelle force-pushed the query-and-get-endpoint branch from 65dbc78 to 336bba8 Compare January 8, 2024 22:28
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@christianhelle christianhelle merged commit b8009dd into main Jan 8, 2024
740 checks passed
@christianhelle christianhelle deleted the query-and-get-endpoint branch January 8, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Already defines a member with the same parameter types
1 participant