Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where codeGeneratorSettings arrayType setting is not respected in Refit interface #257

Merged

Conversation

christianhelle
Copy link
Owner

This resolves #255

@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Dec 20, 2023
@christianhelle christianhelle self-assigned this Dec 20, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03a2b33) 98.22% compared to head (7387a17) 98.30%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   98.22%   98.30%   +0.07%     
==========================================
  Files          57       60       +3     
  Lines        1969     2060      +91     
==========================================
+ Hits         1934     2025      +91     
  Misses         18       18              
  Partials       17       17              
Flag Coverage Δ
unittests 98.30% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle merged commit ef35219 into main Dec 20, 2023
780 checks passed
@christianhelle christianhelle deleted the return-types-should-respect-code-generator-settings branch December 20, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to change arrayType to List or IList
1 participant