Upgrade to .NET 8.0 #250
Merged
Upgrade to .NET 8.0 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overall target framework of the project, including Refitter, Refitter.SourceGenerator.Tests, MinimalApi and Refitter.Tests, has been updated from .NET 6.0 to .NET 8.0. This is to leverage the updated features and improvements in .NET 8.0, allowing the project to stay up-to-date with the latest technology. Following this change, the launch.json file is also modified to point to the updated .NET 8.0 framework. This will ensure the smooth operation of the project and compatibility with the .NET 8.0 version.
The changes in template-url.yml and template.yml involve the inclusion of .NET 8 in both copying output files to ConsoleApp and building generated code steps. This update brings the CI workflows up-to-date with the latest .NET version, thus ensuring that the application remains compatible with it.
The version of the Refitter.SourceGenerator package in Directory.Build.props has been updated from 0.8.2 to 0.8.6. This change updates the referenced package to the latest version.
A new project targeting .NET 8 framework, named Net8, has been added to the SourceGenerator solution. The solution file has been updated accordingly to include this new project in its configuration. This extends the solution's support to the newer version of .NET framework.
This commit modifies the project reference in the MinimalApi.csproj file, adding a "ReferenceOutputAssembly" attribute set to false. The layout of package references has also been adjusted, without affecting the versions of any packages used.
Updated the project reference path for Refitter.SourceGenerator in the Refitter.SourceGenerator.Tests.csproj file. Also added the ReferenceOutputAssembly attribute and set it to false to avoid unnecessary assembly outputs.
The default parameter for 'parent' in the 'Counted' function has been changed from null to an empty string. This change ensures that even if no parent is specified, the function will not fail due to a null reference exception.
The change ensures that the variable interfaceName is always initialized before use by setting it to null, preventing possible null reference exceptions further down the code.
The Serializable attribute and related protected constructor (used for serialization) were removed from the OpenApiValidationException class. This suggests there's no longer a need to serialize instances of this exception, likely due to changes in exception handling or data persistence strategy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 57 57
Lines 1969 1969
=======================================
Hits 1934 1934
Misses 18 18
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here upgrade the CLI tool target framework to .NET 8.0