-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JetBrains Qodana GitHub workflow #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new GitHub Actions workflow for running Qodana, a JetBrains code quality tool, on every push and pull request to the main branch. This workflow runs Qodana Scan on an ubuntu-latest runner and uses QODANA_TOKEN for authentication. It is necessary to maintain the code quality and ensure standards are met before merging into main branch.
Modified the '.github/workflows/qodana.yml' file to update the Qodana action for CI workflows. Added arguments specifying project directory and fixing push setting. These changes ensure that the code analysis targets the source folder and that any potential fixes are pushed to the correct place, enhancing the CI workflows and our code quality.
The Qodana GitHub action arguments were updated to include quotes around the project directory path. This was done to ensure that the path-string passed as argument is being interpreted correctly.
In the GitHub workflow configuration for Qodana, the file path given in the arguments for the 'Qodana Scan' step was updated. It changed from relative format ("src") to an absolute one (./src). This was done to help keep the path reference unambiguous across different environments or use-cases.
Changed the argument from '--project-dir' to '-i' in the GitHub workflow file for Qodana action. This alteration is in accordance with the recent Qodana's command-line interface update.
Changed the Qodana Scan directory path in the GitHub workflow from './src' to 'src'. This aims to address the scanning issue that was identified where Qodana was unable to find the source directory. The change will allow Qodana to properly locate and scan the source code.
Updated the arguments used in the Qodana scan in our GitHub actions workflow. Instead of simply targeting the "src" directory, we are now specifically targeting the "Refitter.sln" solution within the "src" directory. This change was made to narrow the focus of the scan, and improving the relevance and effectiveness of the scan results.
The Qodana scan path in the .github/workflows/qodana.yml file was mistakenly set to "src/Refitter.sln". This commit corrects it to "Refitter.sln", ensuring that the Qodana scan properly locates the solution file.
Kudos, SonarCloud Quality Gate passed!
|
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new GitHub Actions workflow for running Qodana, a JetBrains code quality tool, on every push and pull request to the main branch. This workflow runs Qodana Scan on an ubuntu-latest runner and uses QODANA_TOKEN for authentication. It is necessary to maintain the code quality and ensure standards are met before merging into main branch.