Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JetBrains Qodana GitHub workflow #201

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Add JetBrains Qodana GitHub workflow #201

merged 8 commits into from
Oct 26, 2023

Conversation

christianhelle
Copy link
Owner

Added a new GitHub Actions workflow for running Qodana, a JetBrains code quality tool, on every push and pull request to the main branch. This workflow runs Qodana Scan on an ubuntu-latest runner and uses QODANA_TOKEN for authentication. It is necessary to maintain the code quality and ensure standards are met before merging into main branch.

Added a new GitHub Actions workflow for running Qodana, a JetBrains code quality tool, on every push and pull request to the main branch. This workflow runs Qodana Scan on an ubuntu-latest runner and uses QODANA_TOKEN for authentication. It is necessary to maintain the code quality and ensure standards are met before merging into main branch.
@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Oct 26, 2023
@christianhelle christianhelle self-assigned this Oct 26, 2023
Modified the '.github/workflows/qodana.yml' file to update the Qodana action for CI workflows. Added arguments specifying project directory and fixing push setting. These changes ensure that the code analysis targets the source folder and that any potential fixes are pushed to the correct place, enhancing the CI workflows and our code quality.
The Qodana GitHub action arguments were updated to include quotes around the project directory path. This was done to ensure that the path-string passed as argument is being interpreted correctly.
In the GitHub workflow configuration for Qodana, the file path given in the arguments for the 'Qodana Scan' step was updated. It changed from relative format ("src") to an absolute one (./src). This was done to help keep the path reference unambiguous across different environments or use-cases.
Changed the argument from '--project-dir' to '-i' in the GitHub workflow file for Qodana action. This alteration is in accordance with the recent Qodana's command-line interface update.
Changed the Qodana Scan directory path in the GitHub workflow from './src' to 'src'. This aims to address the scanning issue that was identified where Qodana was unable to find the source directory. The change will allow Qodana to properly locate and scan the source code.
Updated the arguments used in the Qodana scan in our GitHub actions workflow. Instead of simply targeting the "src" directory, we are now specifically targeting the "Refitter.sln" solution within the "src" directory. This change was made to narrow the focus of the scan, and improving the relevance and effectiveness of the scan results.
The Qodana scan path in the .github/workflows/qodana.yml file was mistakenly set to "src/Refitter.sln". This commit corrects it to "Refitter.sln", ensuring that the Qodana scan properly locates the solution file.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@christianhelle christianhelle merged commit 88bd2e1 into main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant