Skip default values when collecting feature usages for Analytics #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the code readability and maintainability in the Analytics.cs by extracting the conditions used for determining if a feature can be logged from the iteration over Settings properties into a separate CanLogFeature method. This change was necessary to clean up complex conditionals and also prepare the code for any future conditions that might be added for validating a loggable feature.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 37 37
Lines 1178 1178
=======================================
Hits 1160 1160
Misses 6 6
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
christianhelle
deleted the
ignore-default-values-for-feature-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here improved the code readability and maintainability in the
Analyticsclass by extracting the conditions used for determining if a feature can be logged from the iteration over Settings properties into a separateCanLogFeature()method. This change was necessary to clean up complex conditionals and also prepare the code for any future conditions that might be added for validating a loggable feature.