Fix word ordering in CSV (and HTML) output

[ctrueden]

The problem is that the options word order may not correspond to the words_by_date word order. So for safety, we extract the words directly from words_by_date rather than relying on the options values.

[ctrueden]

In case you're curious, I was analyzing this repository as follows:

git pissed --words=FIXME,HACK,TODO

The problem became obvious because that repo has hundreds of TODOs but only a few FIXMEs and HACKs.

[chrishunt]

How do you feel about changing this slightly and pulling the values out in the order that they were provided in the options? This is a bit more clear to me since we avoid the [0][1] shenanigans.

 def table
   [["date", *options.words].join(',')].tap do |table|
     words_by_date.each do |date, words|
-      table << [date, *words.values].join(',')
+      table << [date, words.values_at(*options.words)].join(',')
     end
   end
 end

[ctrueden]

Thanks for your quick response! I agree that ordering things the same as specified in the options is most natural for users. I am a total Ruby noob—I was happy I managed to fix this bug at all, much less doing it the "right" way—so I will definitely defer to your preference here. As such, feel free to cherry pick + amend + push to master + close the PR. Or would you rather I amend the branch myself with this change? Either way is fine with me!

[chrishunt]

@ctrueden Great catch! This would only happen on 1.8.7, but it seems most systems do default to that when ran with git pissed instead of git-pissed. 🎉

[ctrueden]

Indeed:

$ ruby --version
ruby 1.8.7 (2012-02-08 patchlevel 358) [universal-darwin12.0]
$ sw_vers 
ProductName:    Mac OS X
ProductVersion: 10.8.4
BuildVersion:   12E55

And not being a Ruby guy, I hadn't bothered installing a newer one with Homebrew...

[ctrueden]

Thanks!

[chrishunt]

@ctrueden Thank you, all set. I'll make a new release. 🍻