forked from nodejs/node-v0.x-archive
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dgram: make send cb act as "error" event handler.
This allows users to provide a callback that handles potential errors resulting from a `socket.send` call. The original behavior of emitting the error event on the socket is preserved. Fixes nodejs#4846.
- Loading branch information
1 parent
bd988a5
commit 425a37d
Showing
2 changed files
with
53 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var dgram = require('dgram'); | ||
|
||
var socket = dgram.createSocket('udp4'); | ||
var buffer = new Buffer('gary busey'); | ||
var order = 0; | ||
|
||
var callbackOrder; | ||
var eventOrder; | ||
|
||
// assert that: | ||
// * callbacks act as "error" listeners if given. | ||
// * callbacks and error events are emitted in a certain order. | ||
// | ||
socket.send(buffer, 0, buffer.length, 100, 'dne.example.com', callbackOnly); | ||
|
||
function callbackOnly(err) { | ||
assert.ok(err); | ||
|
||
socket.once('error', onEvent); | ||
|
||
socket.send(buffer, 0, buffer.length, 100, 'dne.example.com', onCallback); | ||
} | ||
|
||
function onEvent(err) { | ||
assert.ok(err); | ||
eventOrder = order++; | ||
check(); | ||
} | ||
|
||
function onCallback(err) { | ||
assert.ok(err); | ||
callbackOrder = order++; | ||
check(); | ||
} | ||
|
||
function check() { | ||
if (eventOrder !== undefined && callbackOrder !== undefined) { | ||
assert.ok(eventOrder < callbackOrder); | ||
socket.close(); | ||
} | ||
} |