WIP npm assets #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions: Add support for asset related actions install: Add new assets config options actions: Only report the number of actions we'll run copy-tree: Copy assets list diff-trees: Generate asset diffs install/deps: Remove unused third argument to doesChildVersionMatch install/deps: Pass in log to removeObsoleteDep from resolveWithNewModule install/deps: Add asset resolution install: Resolve assets assets shrinkwrap: fix verb checkPackageFile → readPackageFile install: Allow more general reporting of actions against arguments
ceejbot
merged this pull request
into
chrisdickinson:you-cant-spell-ex-mea-sententia-without-e-s-m
ceejbot
pushed a commit
that referenced
this pull request
Jan 12, 2018
Remove a pointless adapter frame by fixing up the function's formal
parameter count. Before:
frame #0: 0x000033257ea446d5 onParserExecute(...)
frame #1: 0x000033257ea3b93f <adaptor>
frame #2: 0x000033257ea41959 <internal>
frame #3: 0x000033257e9840ff <entry>
After:
frame #0: 0x00000956287446d5 onParserExecute(...)
frame #1: 0x0000095628741959 <internal>
frame #2: 0x00000956286840ff <entry>
PR-URL: nodejs#17693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will land in npm w/ multiple commits, but for our purposes here squashing seemed best.
Installation
npm iinstalls fromassetDependenciesinpackage.jsonandassetssection ofpackage-lock.jsonnpm i --no-assets,npm i --only=prod,npm i --only=devnpm i --only=assetsMutation
npm asset install asset-namenpm a i asset-namenpm asset rm asset-nameListing
npm asset lsAsset Rewriting
This is currently the super naive implementation using regexp from
assetize.TODO