Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set job timestamp to ISO 8601 format so it can be properly 'relatized' #95

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set job timestamp to ISO 8601 format so it can be properly 'relatized' #95

wants to merge 3 commits into from

Conversation

richardkmiller
Copy link
Contributor

This is a tiny thing, but resque-web wasn't showing relative dates, e.g. "just now", with the current date format. I changed it to ISO 8601 to play better with resque-web's jQuery relatize_date.

@chrisboulton
Copy link
Owner

It looks like this was a change made to Resque a few months ago: defunkt/resque@df08385

Don't suppose you know if it's been released as such?

I'd like to bring this in, but it looks like a backwards incompatible change with older versions of Resque. I'd say 1.3 (next release) is the best one because there are already other compatibility breaking changes.

Thanks for this. 👍

@richardkmiller
Copy link
Contributor Author

Interestingly, I changed the date format to ISO 8601 so it would work, not knowing that it was also being changed in [Ruby] Resque. We're using Resque 1.23.0 from Ubuntu 12.04 gems and that change is not yet present.

Releasing with 1.3 works for me.

@ruudk
Copy link
Contributor

ruudk commented Mar 27, 2013

Can you please update your PR so that it also includes the timestamp set in lib/Resque/Failure/Redis.php?

$data->failed_at = date('c');

I'm using the dev-master version of PHP-Resque so I'd like to see this merged :)

@richardkmiller
Copy link
Contributor Author

@ruudk Thanks for the heads up! Done.

@danhunsaker
Copy link
Contributor

1.3 is still looming. It would probably be good to define it and get the Internet working on churning out the code to get it released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants