Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return false if the fork function is unavailable #299

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Conversation

chrisboulton
Copy link
Owner

Deals with #93 and #94

@lauripiisang
Copy link
Contributor

lauripiisang commented Sep 22, 2016

Good stuff, but in bin/resque, shouldn't the program at least say something if you are using a forking OS, but don't have the appropriate module ? E.g. darwin or unix + no pcntl_fork extension.
With this patch, it turns from a fail into a silent fail, leaving people scratching their heads over performance.

@chrisboulton
Copy link
Owner Author

Honestly, I think anyone using bin/resque to manage more than one worker is asking for trouble and should really be using a real process manager to manage a pool of workers (monit, daemon tools, something else). I've gone ahead and pushed up a "fix" for the above so it at least bails out. That'll do for now.

@lauripiisang
Copy link
Contributor

lauripiisang commented Oct 11, 2016

Honestly, I think anyone using bin/resque to manage more than one worker is asking for trouble and should really be using a real process manager to manage a pool of workers

Perhaps this should be documented in the README under "Running multiple workers".

@chrisboulton chrisboulton merged commit c928347 into master Oct 11, 2016
@chrisboulton chrisboulton deleted the fork-return branch October 11, 2016 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants