Skip to content
This repository has been archived by the owner on Nov 12, 2024. It is now read-only.

Add open source licenses screen to Android app #1528

Merged
merged 25 commits into from
Sep 13, 2023
Merged

Add open source licenses screen to Android app #1528

merged 25 commits into from
Sep 13, 2023

Conversation

penkzhou
Copy link
Contributor

@penkzhou penkzhou commented Sep 10, 2023 •
edited by chrisbanes
Loading

current only enable on QaDebug flavor on android platform.

Test path:

  1. execute ':android-app:app:generateLicensesAsset' task
  2. run the project with android device.
  3. go to the settings screen.
  4. click the "View Open Source Licenses" item
  5. check the "Open Source Licenses" page.

screenshot(video):

Screen_recording_20230910_202410.mp4

Fixes #1471

@penkzhou penkzhou mentioned this pull request Sep 10, 2023
Closed
chrisbanes
chrisbanes reviewed Sep 11, 2023
View reviewed changes
Copy link
Owner

@chrisbanes chrisbanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thanks! Added some comments below.

Also, I think we should rename the packages and modules to licenses rather than opensource. It's a lot clearer imo.

android-app/app/build.gradle.kts Outdated Show resolved Hide resolved
android-app/app/src/main/assets/generated_licenses.json Outdated Show resolved Hide resolved
data/opensource/build.gradle.kts Outdated Show resolved Hide resolved
android-app/app/src/main/assets/generated_licenses.json Outdated Show resolved Hide resolved
data/opensource/build.gradle.kts Outdated Show resolved Hide resolved
data/opensource/src/commonMain/kotlin/app/tivi/data/opensource/OpenSourceState.kt Outdated Show resolved Hide resolved
data/opensource/src/androidMain/kotlin/app/tivi/data/opensource/store/AndroidOpenSourceStore.kt Outdated Show resolved Hide resolved
settings.gradle.kts Show resolved Hide resolved
settings.gradle.kts Show resolved Hide resolved
ui/opensource/src/commonMain/kotlin/app/tivi/settings/opensource/OpenSource.kt Outdated Show resolved Hide resolved
@chrisbanes
Copy link
Owner

Thanks for the changes! I think this is ready to go in. Can you please merge in main as that contains some fixes for CI runs from forks?

@chrisbanes chrisbanes enabled auto-merge (squash) September 12, 2023 18:03
auto-merge was automatically disabled September 12, 2023 18:27

Head branch was pushed to by a user without write access

@chrisbanes chrisbanes changed the title add open source license screen Add open source licenses screen to Android app Sep 13, 2023
@chrisbanes chrisbanes merged commit 725c3f1 into chrisbanes:main Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisbanes chrisbanes chrisbanes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support showing licenses in About page
2 participants
@penkzhou @chrisbanes