Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make
node-dtrace-provider
compatible with changes in v8 and allows the usage of the library with Node.JS 12. I ran the tests both for master with node10.15.2
and on the branch with node12.5.0
and on both I had 670 passing tests out of 699 total tests. I tested on MacOS 10.14.5 and disable SIP by executingcsrutil disable
in recovery mode. @chrisa do you have a continuous integration setup where I could test this PR.