Skip to content

Commit

Permalink
Change the repo fetch script used in integration tests (flutter#17943)
Browse files Browse the repository at this point in the history
* change the repo fetch script to recognize candidate versions such as flutter-1.17-candidate.3. Originally the script only accepted branches such as v0.7.3 as valid engine branches.

* addressing reviewer comments: changing the release regular expression
  • Loading branch information
Nurhan Turgut authored Apr 25, 2020
1 parent 3999ef9 commit 4f888d6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/clone_flutter.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ cd $ENGINE_PATH/src/flutter
# Special handling of release branches.
ENGINE_BRANCH_NAME=`git branch | grep '*' | cut -d ' ' -f2`
versionregex="^v[[:digit:]]+\."
releasecandidateregex="^flutter-[[:digit:]]+\.[[:digit:]]+-candidate\.[[:digit:]]+$"
ON_RELEASE_BRANCH=false
echo "Engine on branch $ENGINE_BRANCH_NAME"
if [[ $ENGINE_BRANCH_NAME =~ $versionregex ]]
if [[ $ENGINE_BRANCH_NAME =~ $versionregex || $ENGINE_BRANCH_NAME =~ $releasecandidateregex ]]
then
echo "release branch $ENGINE_BRANCH_NAME"
ON_RELEASE_BRANCH=true
Expand Down

0 comments on commit 4f888d6

Please sign in to comment.