Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate UI to a real UI framework #402

Closed
19 of 20 tasks
chreden opened this issue Nov 29, 2018 · 2 comments · Fixed by #883
Closed
19 of 20 tasks

Migrate UI to a real UI framework #402

chreden opened this issue Nov 29, 2018 · 2 comments · Fixed by #883
Assignees
@chreden
Labels
refactoring ui
Milestone
2.0.0

Comments

@chreden
Copy link
Owner

chreden commented Nov 29, 2018 •
edited
Loading

Migrate to ImGui

Tasks:

Remaining tests:

  • Camera Controls #886
  • Camera Position
  • Console
  • Go To
  • Level Info
  • Items Window
  • Rooms Window
  • Route Window
  • Triggers Window
@chreden chreden added the Needs Review Needs refinement label Dec 9, 2019
@chreden
Copy link
Owner Author

chreden commented Jan 18, 2022

This might be better and is far smaller: https://github.com/ocornut/imgui

@chreden chreden added ui in progress and removed Needs Review Needs refinement labels Jan 18, 2022
@chreden chreden self-assigned this Jan 18, 2022
@chreden
Copy link
Owner Author

chreden commented Jan 18, 2022

Might be useful: ocornut/imgui#269

chreden added a commit that referenced this issue Jan 19, 2022
@chreden
Add imgui 1.86 to external folder
7229590 
To experiment with as a UI replacement
#402
chreden added a commit that referenced this issue Jan 19, 2022
@chreden
Hack in a test window for ImGui
9a5f21f 
#402
chreden added a commit that referenced this issue Jan 19, 2022
@chreden
Convert view options to imgui
658b257 
#402
chreden added a commit that referenced this issue Jan 21, 2022
@chreden
Selectable trigger in items window
28beb03 
#402
chreden added a commit that referenced this issue Jan 21, 2022
@chreden
Select item in list
c333b4b 
#402
chreden added a commit that referenced this issue Jan 21, 2022
@chreden
Sorting items
f969457 
#402
chreden added a commit that referenced this issue Jan 21, 2022
@chreden
Fix selection and checkbox size, window closing
c045824 
#402
chreden added a commit that referenced this issue Jan 21, 2022
@chreden
Remove old UI from ItemsWindow
987b08a 
#402
chreden added a commit that referenced this issue Jan 21, 2022
@chreden
Split into functions
b4caa39 
#402
chreden added a commit that referenced this issue Jan 22, 2022
@chreden
Comment out tests
2bdff24 
Also put nav selection into triggered by.
#402
chreden added a commit that referenced this issue Jan 22, 2022
@chreden
Start on triggers window
0cd1cfd 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Functionality for triggers
aad97c9 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Remove old UI
e251459 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Add ImGui to external folder
fbad386 
Add docking branch of ImGui from commit 3e0d6ec895483e33a663d3cfc1c58f1cafbe978c
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Hack in a test window for ImGui
b514ec1 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Convert view options to imgui
4ec6813 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Selectable trigger in items window
3336ff6 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Select item in list
a6f648d 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Sorting items
1822ed8 
#402
chreden added a commit that referenced this issue Jan 23, 2022
@chreden
Fix selection and checkbox size, window closing
24a4532 
#402
chreden added a commit that referenced this issue Feb 16, 2022
@chreden
Convert context menu, room navigator tests
66c796d 
#402
chreden added a commit that referenced this issue Feb 16, 2022
@chreden
Convert settings window and camera controls
15d00ff 
#402
chreden added a commit that referenced this issue Feb 16, 2022
@chreden
Convert remaining ids, remove old method
992c9c3 
#402
chreden added a commit that referenced this issue Feb 16, 2022
@chreden
Move test id to own file
4ea5a21 
#402
chreden added a commit that referenced this issue Feb 17, 2022
@chreden
Finish go to room tests, improve testimgui
f8a4617 
Finish go to room tests
Split input into click, type, press
#402
chreden added a commit that referenced this issue Feb 17, 2022
@chreden
Restore one triggers window test
abf3dec 
#402
chreden added a commit that referenced this issue Feb 18, 2022
@chreden
Add another triggers window tests
827a22f 
#402
chreden added a commit that referenced this issue Feb 18, 2022
@chreden
A few more trigger tests
586fe15 
#402
chreden added a commit that referenced this issue Feb 18, 2022
@chreden
Triggers window tests
df81df4 
#402
chreden added a commit that referenced this issue Feb 18, 2022
@chreden
Fix console size
379559e 
#402
chreden added a commit that referenced this issue Feb 19, 2022
@chreden
Add console tests
1639fa5 
#402
chreden added a commit that referenced this issue Feb 20, 2022
@chreden
level info test and rendered text hook
da46300 
#402
chreden added a commit that referenced this issue Feb 20, 2022
@chreden
Some route window tests
501d524 
Route window tests
Also remove old hack in application di
#402
chreden added a commit that referenced this issue Feb 20, 2022
@chreden
Change input check to input instead of keyboard
c0b0bce 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
A test for route window
ab3f12f 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
More route window tests
636c0ea 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
Update route window tests
d5eaa6e 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
Command and triggered by sorting
aa87bbe 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
Remove stack tool
2d86bb7 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
Swap notes and rando sections
6b5c7e9 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
Fix some table sizing
5383ba0 
#402
chreden added a commit that referenced this issue Feb 21, 2022
@chreden
PR changes
ec3f50b 
#402
@chreden chreden mentioned this issue Feb 21, 2022
Merged
chreden added a commit that referenced this issue Feb 22, 2022
@chreden
Add imgui to readme and about, number the rooms windows
cd2497f 
#402
chreden added a commit that referenced this issue Feb 22, 2022
@chreden
Fix camera rotation entry
69ae539 
Previously only one of the values was being converted to radians.
#402
chreden added a commit that referenced this issue Feb 22, 2022
@chreden
Fix tooltip stickyness and hide column visibility
4171675 
#402
chreden added a commit that referenced this issue Feb 22, 2022
@chreden
Convert UI to Dear ImGui (#883)
fe21a21 
This PR removes the existing homemade trview UI system and replaces it with Dear ImGui which was added in a previous PR. Almost all functionality was retained and a few extra bits have come for free. This should hopefully make new features be made faster as there won't be as much fiddling around with the UI.

Changes:
- Remove `trview.ui`, `trview.ui.render`, `trview.ui.tests` and all contained files
- Convert all UI elements to use ImGui
- Create something resembling a testing framework for ImGui - this lets the tests click on element and check some of their properties. This uses the ImGui testing hooks plus a couple of others that I added.
- Convert all tests in `trview.app.tests` to test ImGui using the system mentioned previously.

Closes #402
@chreden chreden added this to the Next milestone Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chreden chreden

Labels
refactoring ui
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Convert UI to Dear ImGui chreden/trview
1 participant
@chreden