ignore attribute if injected value is null or undefined #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking over the PRs, it appears this is a different implementation of #57 |
|
cherry-picked your additional tests into #57, thanks! unfortunately the squash-merge removed your credit from the commit log, sorry about that :/ i did add you to the gh release notes instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Often when injecting the value for a property it may resolve as
undefinedornull. These more often than not can be treated as not being assigned, however the current implementation sets them to the string value"undefined"or"null".This PR introduces a change to ignore arguments which would evaluate to
nullorundefined.Look at the updated tests to see the full scope of this change.