-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state.query not set until navigate #549
Comments
Yeah, it should always be in there. Definitely sounds like a bug.
…On Fri, Aug 18, 2017 at 5:38 AM Jon-Kyle ***@***.***> wrote:
When going to a direct link with a query string, such as /example?foo=bar,
the state object does not contain query. But, if you navigate to that URL
by clicking a link, it’ll appear as expected.
That seems to be a bug, but just checking the intent before filing a PR.
One other question; should query always be in state, similar to params?
Could reduce a check or two.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#549>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWleo4VXSL6HVDL25ZiJCUzldwDdG7-ks5sZQc4gaJpZM4O7EEL>
.
|
Just ran into this as well. The |
Yeah, we should probably document properly that all of these values are
only initialized _after_ DOMContentLoaded
…On Mon, Sep 4, 2017, 19:01 Maximilian Antoni ***@***.***> wrote:
Just ran into this as well. The state.query object is populated properly,
but I have to delay reading from it. It's not yet populated during model
initialization.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#549 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACWleqRx0zJ7FPzsTYeQHKDr3m-kPJ6sks5sfCz_gaJpZM4O7EEL>
.
|
4 tasks
Should be fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When going to a direct link with a query string, such as
/example?foo=bar
, thestate
object does not containquery
. But, if you navigate to that URL by clicking a link, it’ll appear as expected.That seems to be a bug, but just checking the intent before filing a PR. One other question; should
query
always be instate
, similar toparams
? Could reduce a check or two.The text was updated successfully, but these errors were encountered: