Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state.query not set until navigate #549

Closed
jondashkyle opened this issue Aug 18, 2017 · 4 comments
Closed

state.query not set until navigate #549

jondashkyle opened this issue Aug 18, 2017 · 4 comments

Comments

@jondashkyle
Copy link

When going to a direct link with a query string, such as /example?foo=bar, the state object does not contain query. But, if you navigate to that URL by clicking a link, it’ll appear as expected.

That seems to be a bug, but just checking the intent before filing a PR. One other question; should query always be in state, similar to params? Could reduce a check or two.

@yoshuawuyts
Copy link
Member

yoshuawuyts commented Aug 18, 2017 via email

@mantoni
Copy link
Contributor

mantoni commented Sep 4, 2017

Just ran into this as well. The state.query object is populated properly, but I have to delay reading from it. It's not yet populated during model initialization.

@yoshuawuyts
Copy link
Member

yoshuawuyts commented Sep 5, 2017 via email

@yoshuawuyts
Copy link
Member

Should be fixed in choo@6.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants