Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Add flags & premium type to User #6

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Conversation

vince614
Copy link

No description provided.

@chonsser chonsser self-requested a review December 27, 2020 20:47
@chonsser
Copy link
Owner

Hey @vince614 - it's great to see your pull request. I have a single question - why the isBot and other getters like isMfaEnabled have changed to non-strict return values? All other changes are good.

@vince614
Copy link
Author

Hay @chonsser, I remove them because they are not mandatory.

Copy link
Owner

@chonsser chonsser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll make a new 1.0.11 release for these changes. Thanks for your support @vince614!

@chonsser chonsser merged commit 9be797f into chonsser:master Dec 28, 2020
@chonsser
Copy link
Owner

Hey @vince614 - your pull request broke the tests. I've updated the tests to match your new features and added an additional test check on every new pull request. The latest version of this OAuth provider lib is v1.1.0 which requires PHP 7.3.

Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants