Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to visualization module #944

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fixes to visualization module #944

merged 1 commit into from
Feb 24, 2022

Conversation

zhang-ivy
Copy link
Contributor

Description

Make fixes to the visualization module related to:

  • Pymol frames are 1-indexed, but the module had been assuming it was 0-indexed
  • Bug: self._unique_old/new should be self._unique_old/new_selection
  • Renaming an object after loading isn't working, so instead, just load the objects as old and new directly
  • Allow color of old residue to be different from the color of the new residue
  • Change background protein transparency
  • Remove "hide spheres" when we are using stick representation (shouldn't be necessary)
  • Do not allow stick/sphere transparencies to fade to transparency 1.0 (completely transparent) -- make the max transparency 0.7, as there are weird visual artifacts when it is 1.0 (the stick/sphere looks white)
  • Clarifications to comments/docstrings

Motivation and context

Resolves #???

How has this been tested?

Change log


@zhang-ivy zhang-ivy changed the title fixes to visualization module Fixes to visualization module Feb 24, 2022
@zhang-ivy zhang-ivy added this to the 0.9.4 Release milestone Feb 24, 2022
@zhang-ivy zhang-ivy mentioned this pull request Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #944 (3658e83) into main (9beb9b0) will decrease coverage by 0.91%.
The diff coverage is 0.00%.

Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for improving this, @zhang-ivy!

@ijpulidos ijpulidos merged commit 10ec6d9 into main Feb 24, 2022
@ijpulidos ijpulidos deleted the fix-visualization branch February 24, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants