Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacks now that upstream has updated packages #868

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

mikemhenry
Copy link
Contributor

Description

Removed forks when installing openmm nightly

Motivation and context

Now that parmed has made a new release to support the openmm name change + we just cut (will be on conda-forge soon) a new openmoltools release, these CI hacks are no longer needed.

Resolves #798

How has this been tested?

Tested on CI

Change log

CI no longer requires forks for openmm namespace changes.  

@mikemhenry
Copy link
Contributor Author

Just waiting for the openmoltools release to show up here https://github.com/conda-forge/openmoltools-feedstock/pulls

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #868 (03d34be) into master (c1f5769) will decrease coverage by 0.01%.
The diff coverage is n/a.

@ijpulidos
Copy link
Contributor

Nice!... I think we could also get rid of pinning the openmm version in


What do you think?

@ijpulidos
Copy link
Contributor

We should probably also fix this in the conda-forge feedstock meta.yml file that I changed to deal with this at the time. Right?

@mikemhenry
Copy link
Contributor Author

Nice!... I think we could also get rid of pinning the openmm version in

What do you think?

Yes I will do that now...

We should probably also fix this in the conda-forge feedstock meta.yml file that I changed to deal with this at the time. Right?

On our next release, we should bump it up to 7.6.x

@mikemhenry mikemhenry merged commit 3ead935 into master Sep 17, 2021
@mikemhenry mikemhenry deleted the feat/remove_ci_hacks branch September 17, 2021 16:12
@ijpulidos ijpulidos mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove forks from CI once ParmEd and openmoltools releases are updated
2 participants