Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pytest runner #763

Merged
merged 7 commits into from
Feb 12, 2021
Merged

Switch to pytest runner #763

merged 7 commits into from
Feb 12, 2021

Conversation

mikemhenry
Copy link
Contributor

As a first pass in improving our testing, we are going to switch to using pytest to run tests. Because of the compatibility between pytest and nose we shouldn't need to do anything to the old tests, but we should start writing new tests using pytest features.

@mikemhenry
Copy link
Contributor Author

Note: I biased this PR off of #761 since it will be merged soon and fixes some issues with the testing environment.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #763 (fc1e0d5) into master (317a3bb) will decrease coverage by 8.97%.
The diff coverage is n/a.

@mikemhenry mikemhenry mentioned this pull request Feb 12, 2021
@mikemhenry mikemhenry force-pushed the feat/switch_to_pytest_runner branch from a1f2f13 to 7fe576b Compare February 12, 2021 19:32
@mikemhenry mikemhenry requested a review from jaimergp February 12, 2021 19:34
@jaimergp
Copy link
Member

Awesome, works right away!

Minor things:

  • This kind of warning is probably due to a docstring containing a literal \P (as in C:\Program Files), or maybe some kind of latex formula. They will go away as soon as you turn those docstrings into raw-docstrings (r"""some text""")

By the way, this might be a good moment to enable tests for the examples/ directory in a separate GHA step, if that's not planned (also in a different PR if you wish).

@mikemhenry mikemhenry mentioned this pull request Feb 12, 2021
20 tasks
@mikemhenry
Copy link
Contributor Author

Thanks! I will go through and fix those warnings on this PR since they really clog up the CI results. I've made a plan here to add the examples to the CI here #766

@mikemhenry mikemhenry merged commit 8ea1b30 into master Feb 12, 2021
@mikemhenry mikemhenry deleted the feat/switch_to_pytest_runner branch February 12, 2021 22:13
@mikemhenry mikemhenry restored the feat/switch_to_pytest_runner branch January 26, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants