Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove extra OEAddExplicitHydrogens #745

Merged
merged 1 commit into from
Oct 26, 2020
Merged

remove extra OEAddExplicitHydrogens #745

merged 1 commit into from
Oct 26, 2020

Conversation

glass-w
Copy link
Contributor

@glass-w glass-w commented Oct 23, 2020

Removes an extra OEAddExplicitHydrogens statement in createOEMolFromSDF that isn't needed

@zhang-ivy
Copy link
Contributor

@hannahbrucemacdonald -- for some context, we noticed that you were the last one to make changes to createOEMolFromSDF, so we wanted to check to see if you might have just forgotten to delete the second call to OEAddExplicitHydrogens (outside the if statement)? Or if you left it there on purpose?

@hannahbrucemacdonald
Copy link
Contributor

Yep that's a typo --- sorry!

@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #745 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@zhang-ivy zhang-ivy merged commit f640bf8 into master Oct 26, 2020
@zhang-ivy zhang-ivy deleted the fix-oe-sdf branch October 26, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbrucemacdonald hannahbrucemacdonald hannahbrucemacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glass-w @zhang-ivy @hannahbrucemacdonald