Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RESTTopologyFactory test #1188

Merged
merged 2 commits into from
May 8, 2023
Merged

Fix RESTTopologyFactory test #1188

merged 2 commits into from
May 8, 2023

Conversation

zhang-ivy
Copy link
Contributor

Description

Fixed bug in test that checks to see if the non-rest and REST energy match. Should be checking that the absolute value in the difference in energies is < 1.

Motivation and context

Resolves #???

How has this been tested?

Change log


@zhang-ivy zhang-ivy requested a review from ijpulidos April 21, 2023 21:42
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1188 (4a7b217) into main (8e3e423) will decrease coverage by 2.67%.
The diff coverage is 100.00%.

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ijpulidos ijpulidos added this to the 0.10.2 Bugfix release milestone May 8, 2023
@ijpulidos ijpulidos merged commit 53c61b8 into main May 8, 2023
@ijpulidos ijpulidos deleted the fix-rest-test branch May 8, 2023 16:58
mikemhenry pushed a commit that referenced this pull request May 23, 2023
Co-authored-by: Iván Pulido <2949729+ijpulidos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants