Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run dev with newest python version #1165

Merged
merged 17 commits into from
Mar 1, 2023
Merged

Conversation

mikemhenry
Copy link
Contributor

Description

To save some compute time/carbon, we are only going to test dev with the latest python version.

Motivation and context

Resolves #???

How has this been tested?

Change log


@mikemhenry mikemhenry requested a review from ijpulidos February 28, 2023 16:49
@ijpulidos
Copy link
Contributor

In this case we are not using the dev versions from OpenMM, since we currently rely on the matrix.openmm option to install them in

case ${{ matrix.openmm }} in

@ijpulidos
Copy link
Contributor

I just double checked that this is indeed the case for example in https://github.com/choderalab/perses/actions/runs/4295333336/jobs/7485595343#step:7:236

@ijpulidos
Copy link
Contributor

Oh, but according to documentation using include should work for this, exactly as you proposed it. Not sure why it isn't working as expected then.

@mikemhenry
Copy link
Contributor Author

I think I fixed it, the problem (I think) was the lack of telling micromamba to reinstall if the package is in the env. It would be faster and better to use this kind of syntax to install openmm:

extra-specs: |
  python=${{ matrix.python-version }}

but that would then crash on "dev" but would work for the other openmm version strings... but I have an idea!

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1165 (24423b9) into main (c7971db) will not change coverage.
The diff coverage is n/a.

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

I think eventually we do want to think about not having to manually change the openmm dev version every time there's a new build.

@ijpulidos ijpulidos merged commit a24067b into main Mar 1, 2023
@ijpulidos ijpulidos deleted the feat/reduce_ci_matrix_size branch March 1, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants