Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves issue #1150 #1151

Merged
merged 1 commit into from
Feb 2, 2023
Merged

resolves issue #1150 #1151

merged 1 commit into from
Feb 2, 2023

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Jan 26, 2023 •
edited
Loading

Description

Fix issue with test using old CLI

Motivation and context

Resolves #1150

How has this been tested?

tested locally and on lilac, this test is skipped on CI

Change log

@mikemhenry mikemhenry requested a review from ijpulidos January 26, 2023 20:47
ijpulidos
ijpulidos approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We probably want to use the click capabilities to have isolated filesystems and using an instance of the CliRunner but this works for now. LGTM!

@codecov
Copy link

codecov bot commented Jan 26, 2023 •
edited
Loading

Codecov Report

Merging #1151 (926674c) into main (e536cfd) will not change coverage.
The diff coverage is 100.00%.

@mikemhenry mikemhenry merged commit 4e36a6b into main Feb 2, 2023
@mikemhenry mikemhenry deleted the fix/issue_1150 branch February 2, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijpulidos ijpulidos ijpulidos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix resume tests
2 participants
@mikemhenry @ijpulidos