Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_chocolatey does not support licensed edition options/switches #15

Closed
mwtrigg opened this issue May 24, 2020 · 4 comments · Fixed by #70
Closed

win_chocolatey does not support licensed edition options/switches #15

mwtrigg opened this issue May 24, 2020 · 4 comments · Fixed by #70
Assignees
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Milestone

Comments

@mwtrigg
Copy link

mwtrigg commented May 24, 2020

When attempting to install the chocolatey-management-database|service|web packages, I noticed that there was no means of passing a value to the choco --package-parameters-sensitive option. I then also noticed that the other options avaialable to licensed users are also missing.

Is this an oversight, or intentional?

@vexx32 vexx32 added the Question Issues opened for asking questions. These should be converted to discussions label May 24, 2020
@vexx32
Copy link
Member

vexx32 commented May 24, 2020

Up until recently, these modules were part of Ansible's core modules, so while I can't speak for them I would guess that they felt it was better to have the modules mainly support open source Chocolatey features.

We can look at adding some of the licensed edition features if there's a need for it, absolutely. There are some things we'd need to iron out on our end, mainly to do with how we'd handle testing for those features (after all, can't really test those things without a valid Chocolatey license on the Windows agent).

I'm more than happy to take a look at what's missing and add some of the licensed features in as my work schedule permits. If you or anyone else would like to submit PRs for specific features that you have a pressing need for, that's more than welcome as well. 🙂

@vexx32 vexx32 added Improvement Issues that enhances existing functionality, or adds new features Up For Grabs Issues that are available by the community to work on and removed Question Issues opened for asking questions. These should be converted to discussions labels May 24, 2020
@ferventcoder
Copy link
Member

This came up in today's webinar. Something we should definitely look into fixing for the next version of this.

@ferventcoder
Copy link
Member

So Chocolatey will typically ignore most arguments if it doesn't understand them, that's the default. There is one (--install-directory) that it will error on if you use it on an open source edition - b/c so many folks got confused about why that didn't work, we needed to tell them it required a commercial edition.

I would suggest an option called additional_arguments and let those additional things be passed straight to choco. This is similar to what other providers have done for this aspect.

@vexx32 vexx32 added this to the 1.1.x milestone Apr 9, 2021
@vexx32
Copy link
Member

vexx32 commented Apr 9, 2021

Worth noting that we already have:

  • install_args
  • override_args
  • package_params / params

I think it would be best if we made the new option a bit more distinct than just additional_arguments as there may be confusion between some of the existing parameters.

Perhaps something like choco_options / additional_choco_options? Or maybe choco_args 🤔

@vexx32 vexx32 added the 1 - Ready Issue is accepted, milestone added and are ready to be worked on label May 11, 2021
@vexx32 vexx32 modified the milestones: 1.1.x, 1.2.x Jun 2, 2021
@pauby pauby added 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint and removed 1 - Ready Issue is accepted, milestone added and are ready to be worked on labels Jan 21, 2022
vexx32 added a commit to vexx32/chocolatey-ansible that referenced this issue Jan 27, 2022
This allows users to specify arguments that are not explicity supported
by the collection, for example any options that require the chocolatey
licensed extension to be installed.

This also gives us a workaround / stop-gap for any additional arguments
in open source Chocolatey in future, allowing users to specify them
manually until the collection is updated to include those options.
@vexx32 vexx32 added 2 - Working A user or team member has started working on the issue and removed 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint Up For Grabs Issues that are available by the community to work on labels Jan 27, 2022
vexx32 added a commit to vexx32/chocolatey-ansible that referenced this issue Jan 27, 2022
This allows users to specify arguments that are not explicity supported
by the collection, for example any options that require the chocolatey
licensed extension to be installed.

This also gives us a workaround / stop-gap for any additional arguments
in open source Chocolatey in future, allowing users to specify them
manually until the collection is updated to include those options.
vexx32 added a commit to vexx32/chocolatey-ansible that referenced this issue Jan 27, 2022
This allows users to specify arguments that are not explicity supported
by the collection, for example any options that require the chocolatey
licensed extension to be installed.

This also gives us a workaround / stop-gap for any additional arguments
in open source Chocolatey in future, allowing users to specify them
manually until the collection is updated to include those options.
vexx32 added a commit to vexx32/chocolatey-ansible that referenced this issue Jan 31, 2022
This allows users to specify arguments that are not explicity supported
by the collection, for example any options that require the chocolatey
licensed extension to be installed.

This also gives us a workaround / stop-gap for any additional arguments
in open source Chocolatey in future, allowing users to specify them
manually until the collection is updated to include those options.
vexx32 added a commit to vexx32/chocolatey-ansible that referenced this issue Feb 1, 2022
This allows users to specify arguments that are not explicity supported
by the collection, for example any options that require the chocolatey
licensed extension to be installed.

This also gives us a workaround / stop-gap for any additional arguments
in open source Chocolatey in future, allowing users to specify them
manually until the collection is updated to include those options.
vexx32 added a commit to vexx32/chocolatey-ansible that referenced this issue Feb 1, 2022
This allows users to specify arguments that are not explicity supported
by the collection, for example any options that require the chocolatey
licensed extension to be installed.

This also gives us a workaround / stop-gap for any additional arguments
in open source Chocolatey in future, allowing users to specify them
manually until the collection is updated to include those options.
@corbob corbob closed this as completed in #70 Feb 1, 2022
corbob added a commit that referenced this issue Feb 1, 2022
(#15) Allow additional choco args to be passed manually
@pauby pauby added 5 - Released The issue has been resolved, and released to the public for consumption and removed 2 - Working A user or team member has started working on the issue labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants