choco list -e -a returns pre-releases even when --pre is not passed
#2304
Comments
|
Might be related to #1843 |
|
I think we need to clarify if |
|
Without |
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Aug 2, 2021
Due to a prior fix in the logic for `list -e -a`, all packages with the target ID were being returned, regardless of whether the user uses the `--pre` flag or not. Since the same search without `--exact` does not return prerelease versions unless the `--pre` option is also passed, the behaviour for `list -e -a` should match this. This fix modifies the search logic used when listing all package versions with `--exact` to also check for and respect the `--pre` flag from the configuration context, much like other list commands use the setting in this file in other places.
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Aug 2, 2021
Due to a prior fix in the logic for `list -e -a`, all packages with the target ID were being returned, regardless of whether the user uses the `--pre` flag or not. Since the same search without `--exact` does not return prerelease versions unless the `--pre` option is also passed, the behaviour for `list -e -a` should match this. This fix modifies the search logic used when listing all package versions with `--exact` to also check for and respect the `--pre` flag from the configuration context, much like other list commands use the setting in this file in other places. I also did a minor refactor to avoid doing a double query here, now we only call the Search() function if we're actually going to use those results. The code paths for AllVersions completely discard that already, so this just removes the need to call the method unnecessarily.
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Aug 10, 2021
Due to a prior fix in the logic for `list -e -a`, all packages with the target ID were being returned, regardless of whether the user uses the `--pre` flag or not. Since the same search without `--exact` does not return prerelease versions unless the `--pre` option is also passed, the behaviour for `list -e -a` should match this. This fix modifies the search logic used when listing all package versions with `--exact` to also check for and respect the `--pre` flag from the configuration context, much like other list commands use the setting in this file in other places. Also includes a minor refactor to avoid doing a double query here; now we only call the Search() function if we're actually going to use those results. The code paths for AllVersions completely discard that already, so this just removes the need to call the method unnecessarily.
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Aug 12, 2021
Due to a prior fix in the logic for `list -e -a`, all packages with the target ID were being returned, regardless of whether the user uses the `--pre` flag or not. Since the same search without `--exact` does not return prerelease versions unless the `--pre` option is also passed, the behaviour for `list -e -a` should match this. This fix modifies the search logic used when listing all package versions with `--exact` to also check for and respect the `--pre` flag from the configuration context, much like other list commands use the setting in this file in other places. Also includes a minor refactor to avoid doing a double query here; now we only call the Search() function if we're actually going to use those results. The code paths for AllVersions completely discard that already, so this just removes the need to call the method unnecessarily.
gep13
pushed a commit
to vexx32/choco
that referenced
this issue
Aug 19, 2021
Due to a prior fix in the logic for `list -e -a`, all packages with the target ID were being returned, regardless of whether the user uses the `--pre` flag or not. Since the same search without `--exact` does not return prerelease versions unless the `--pre` option is also passed, the behaviour for `list -e -a` should match this. This fix modifies the search logic used when listing all package versions with `--exact` to also check for and respect the `--pre` flag from the configuration context, much like other list commands use the setting in this file in other places. Also includes a minor refactor to avoid doing a double query here; now we only call the Search() function if we're actually going to use those results. The code paths for AllVersions completely discard that already, so this just removes the need to call the method unnecessarily.
gep13
added
the
NO RELEASE NOTES
gep13
changed the title
choco list -e -a returns pre-releases even when --pre is not passedchoco list -e -a returns pre-releases even when --pre is not passed
|
I have marked this issue with |
gep13
added a commit
that referenced
this issue
Aug 19, 2021
…leases (#2304) Make list --exact --all-versions to filter out prereleases by default
|
From what I could tell, although there was a recent fix to make the behaviour this way, (it was briefly "broken" in that |
gep13
removed
the
NO RELEASE NOTES
|
@vexx32 understood. Makes sense. I have removed the |
tapika
added a commit
to tapika/swupd
that referenced
this issue
Jan 9, 2022
SHA-1: 74d7d39 * (chocolatey#2304) Fix list --exact -a for prereleases Due to a prior fix in the logic for `list -e -a`, all packages with the target ID were being returned, regardless of whether the user uses the `--pre` flag or not. Since the same search without `--exact` does not return prerelease versions unless the `--pre` option is also passed, the behaviour for `list -e -a` should match this. This fix modifies the search logic used when listing all package versions with `--exact` to also check for and respect the `--pre` flag from the configuration context, much like other list commands use the setting in this file in other places. Also includes a minor refactor to avoid doing a double query here; now we only call the Search() function if we're actually going to use those results. The code paths for AllVersions completely discard that already, so this just removes the need to call the method unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What You Are Seeing?
Output contains pre-releases
Actual output
What is Expected?
Output should not contain pre-releases when
--preflag isn't passedExpected output
How Did You Get This To Happen? (Steps to Reproduce)
choco upgrade chocolatey --prechoco list -e -a python3Output Log
Full Log Output
The text was updated successfully, but these errors were encountered: