-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ruby) migrated from ferventcoder #702
Conversation
This works for me, not sure why it fails on AV ... |
automatic/ruby/update.ps1
Outdated
@@ -0,0 +1,37 @@ | |||
import-module au | |||
Import-Module "$PSScriptRoot\..\..\scripts\au_extensions.psm1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing "
at the end
probably the reason why the appveyor run fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh... that line i changed in speed didnt have it locally. Thx.
automatic/ruby/README.md
Outdated
|
||
## Package Parameters | ||
|
||
- `InstallDir` - Ruby installation directory, by default `c:\tools\RubyXY` where XY are major and minor version parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add /
to the parameter keys.
There have been several times were users have reported they couldn't use packages with parameters,
It usually turned out that they was missing the /
because the package parameters didn't mention it.
Done, just add choco user |
Sorry, can't add the choco user right now. The package page won't load for me, I'll have a look at it a little later. |
@majkinetor choco have been added. |
This is a great start - however there are multiple running supported versions of Ruby at the same time (like VirtualBox but more). Did those get added to core team yet? |
Case in point, https://rubyinstaller.org/
Also, where there plans to grab https://chocolatey.org/packages/ruby.portable as well? |
@majkinetor issue 57 is about updating the certificates in the OLDER ruby versions, which means some additional functionality into a package version fix. HTH. |
Something like this is planned: majkinetor/au#74 |
I thought this was already supported in the way that we are doing it with VirtualBox? |
Yes, but it is a separate package. With above implementation all would go into the single package, stream would have 1 additional |
Actually, I am a bit mistaken about VBox, I thought it pushes to the different VBox package id. AdmiringWorm did that so I wasn't totally aware how it functions up I looked at it now. Still, it requires a separate folder and is treated as a separate AU package:
so I guess it does make a sense to make it easier. |
@majkinetor although it looks like a separate package, it reuses the original virtualbox scripts, and overrides the packagename variable so it pushes to the same chocolatey package. |
closes #700
Closes at @ferventcoder
Update Ruby to 2.3.3 ferventcoder/chocolatey-packages#238Ruby 2.3.4 and 2.4.1 released ferventcoder/chocolatey-packages#242/cc @ferventcoder