Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this available! I'm playing around with connecting PATH to https://github.com/rdeits/ConditionalJuMP.jl and noticed some opportunities to clean up the code a bit. This PR does two things:
solveLCP
methods withoutvar_name
andcon_name
arguments and replace them with default values. Default argument values in Julia do exactly what you were doing by hand here, so there's no reason to write out the other methods.user_f
anduser_j
functions. You can callcfunction
on a closure with no issues, so we can create a custom cfunction for the user's particular callback.Currently I haven't observed (2) making any performance difference, but I'm planning to build further on that change to solve LCPs (without calling ForwardDiff.jacobian at every iteration).