Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove batchSize #28

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Conversation

willisk
Copy link
Contributor

@willisk willisk commented Jan 25, 2022

batchSize is not required. The implementation should be kept as close to the original as possible. Requiring a certain batch size is better dealt with in inheriting contracts.
Resolves #18

@willisk willisk force-pushed the feature/RemoveBatchSize branch from 55fd038 to 250b726 Compare January 25, 2022 09:33
Copy link
Owner

@chiru-labs chiru-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert styling changes to keep PR changes isolated, rest lgtm

Let's also cut a new version after this goes in because the constructor is a backcompat break

@willisk
Copy link
Contributor Author

willisk commented Jan 27, 2022

I added those the 2 lines in the .prettierrc to because I couldn't get it to look like before with any settings. If you are using specific settings, please add them to the .prettierrc (or describe exactly how you are formatting the files). Currently it looks like only .sol files have styling settings, these however are not even being applied correctly, because the .prettierrc specifies singleQuote: true, but the .sol files currently use double quotes.
If I can figure out how to make the styling match, I'll push again.

@chiru-labs
Copy link
Owner

Got it thanks. How about first pushing the prettier changes as a separate PR to keep things isolated? Can fast-follow approve that one to keep iteration quick

@willisk willisk force-pushed the feature/RemoveBatchSize branch from 68920f1 to 4091174 Compare January 28, 2022 10:20
@willisk
Copy link
Contributor Author

willisk commented Jan 28, 2022

Did you want me to change this to a new version? Is that done under version in package.json?

@cygaar
Copy link
Collaborator

cygaar commented Jan 28, 2022

Nah I can handle the version update when we cut a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments on ERC721A
3 participants