Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surelog parses more attributes for nets, modules, while at it support formal at… #2605

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

alaindargelas
Copy link
Collaborator

…tributes

@alaindargelas alaindargelas marked this pull request as ready for review October 4, 2024 03:10
@kamilrakoczy
Copy link
Collaborator

The change itself looks ok to me, but one of the formal verification tests now fails to parse:

yosys:simple_abc9/abc9.v resulted with: PLUGIN_READ_FAIL, but expected result was: UNMATCHED_MODULE [ERROR]

Could you please check this?

@alaindargelas
Copy link
Collaborator Author

alaindargelas commented Oct 4, 2024

Fixed the reading part with whitebox attr support:
https://github.com/chipsalliance/synlig/pull/2605/files
Looks like another issue is raised after.

@alaindargelas alaindargelas marked this pull request as draft October 4, 2024 16:22
@alaindargelas alaindargelas marked this pull request as ready for review October 4, 2024 21:40
@alaindargelas
Copy link
Collaborator Author

alaindargelas commented Oct 4, 2024

@kamilrakoczy this is passing, modulo one of the actions that failed due to system issue.

blackbox attribute is now correctly handled, even if not the only attribute in a list of attributes (Which is the main fix here).

@alaindargelas alaindargelas changed the title Surelog parses more attributes for nets, while at it support formal at… Surelog parses more attributes for nets, modules, while at it support formal at… Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants