Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set parameterized desiredName on many system components #3641

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

jerryz123
Copy link
Contributor

This improves the naming stability of generated verilog by adding descriptive suffixes to module names. This makes it easier to determine where many important modules are instantiated.

Related issue:

Type of change: bug report | feature request | other enhancement

Impact: no functional change | API addition (no impact on existing code) | API modification

Development Phase: proposal | implementation

Release Notes

@jerryz123 jerryz123 changed the title Set parameterized desiredName on many system componets [WIP] Set parameterized desiredName on many system componets Jun 5, 2024
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do need these features.

Copy link
Contributor

@lordspacehog lordspacehog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@jerryz123 jerryz123 changed the title [WIP] Set parameterized desiredName on many system componets Set parameterized desiredName on many system componets Jun 25, 2024
@jerryz123 jerryz123 changed the title Set parameterized desiredName on many system componets Set parameterized desiredName on many system components Jun 25, 2024
@jerryz123 jerryz123 merged commit ea9979b into dev Jun 25, 2024
26 checks passed
@jerryz123 jerryz123 deleted the naming branch June 25, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants