Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Late Cancel contract to make TileLink implementation compatible with spec #3412

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

sequencer
Copy link
Member

  • remove late cancel API in xbar
  • remove late cancel API in arbiter
  • totally remove ReadyValidCancel

Related issue:

Type of change: bug report | feature request | other enhancement

Impact: no functional change | API addition (no impact on existing code) | API modification

Development Phase: proposal | implementation

Release Notes

@sequencer
Copy link
Member Author

Depends #3414

@jerryz123 jerryz123 self-requested a review July 12, 2023 20:09
@sequencer
Copy link
Member Author

safe to skip the arch tests

@sequencer sequencer merged commit 0b33a74 into dev Jul 13, 2023
24 of 28 checks passed
@sequencer sequencer deleted the remove_late_cancel branch July 13, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants