PLIC Priority RegFieldDesc fix off-by-one #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
reviewed
Nov 9, 2020
aswaterman
approved these changes
Nov 9, 2020
mwachs5
commented
Nov 9, 2020
mwachs5
force-pushed
the
plic-reg-descs
branch
from
719b1b9
to
15987e2
Compare
mwachs5
force-pushed
the
plic-reg-descs
branch
from
9f74018
to
e1967aa
Compare
hcook
pushed a commit
that referenced
this pull request
Nov 18, 2020
…-change Revert "Revert "Merge pull request #2718 from chipsalliance/plic-reg-descs""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: None
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
PLIC Priority registers are now explicitly named with a suffix. This prevents tooling which assumes that the "first" register in a group should have the 0th index ending up with Priority[2] ending up in a register called priority_1, and so on.