Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxTransactionsInFlight to IDMapEntry and OMIdMapEntry #2627

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

hcook
Copy link
Member

@hcook hcook commented Sep 3, 2020

This PR adds a maxTransactionsInFlight field to IDMapEntry and OMIdMapEntry. This field offers an upper-bound on the number of transactions possibly in flight from a given master associated with a range of ids. The calculation is protocol specific; while it is exactly the number of source ids for TileLink, for AXI4 incomplete information forces us to make a conservative overestimate: assume that every single ID could possibly generate the maximum number of transactions (which may or may not be true), and that each source could generate simultaneous read and write transactions using the same ID (which may or may not be true).

Related issue:

Type of change: feature request

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor nitpick about backwards compatibility and public/privateness, which are more for my edification about Scala best practices than anything else.

src/main/scala/amba/axi4/Parameters.scala Outdated Show resolved Hide resolved
@hcook hcook merged commit 90551b2 into master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants