Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use self-location in wake rules #2526

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Use self-location in wake rules #2526

merged 1 commit into from
Jun 17, 2020

Conversation

mmjconolly
Copy link
Contributor

This adds a self-location def rocketChipRoot so that other wake rules can find this repository regardless of where it is located in the collection of repositories that makes up your workspace.

Some repository layouts expect a flat list of repositories while others expect a hierarchy, this helps make a repository location-independent if consumers of the repository use the <reponame>Root definition as a base prefix when referencing components

Related issue:

Type of change: other enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardxia richardxia merged commit 35eb1ca into chipsalliance:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants