Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require RegFieldDesc names match a certain RegEx #2525

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Jun 17, 2020

Related issue: None

Type of change: other enhancement

Impact: API modification

Development Phase: implementation

Release Notes

RegFieldDesc.name and RegFieldDesc.group must match specific regular expression ^[_:A-Za-z][-._:A-Za-z0-9]*$ or the design will not elaborate.

@mwachs5 mwachs5 requested review from drom and richardxia June 17, 2020 16:09
@drom
Copy link
Member

drom commented Jun 18, 2020

DUH/SPIRIT/IPXACT supports xs:Name pattern: ^[_:A-Za-z][-._:A-Za-z0-9]*$
https://github.com/sifive/duh-schema/blob/master/lib/primitive.js#L7

@mwachs5 mwachs5 force-pushed the detect-regmap-names branch from e7e7537 to 2c9e4a2 Compare June 24, 2020 21:24
@mwachs5 mwachs5 force-pushed the detect-regmap-names branch from 2c9e4a2 to 46e0b84 Compare June 25, 2020 13:13
@mwachs5 mwachs5 merged commit ef4c0a4 into master Jun 25, 2020
@mwachs5 mwachs5 deleted the detect-regmap-names branch November 6, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants