-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object model updates for AHB and AXI #2427
Conversation
I'd like @aisha-w-sifive and/or @jmilstead-sifive feedback on this... |
So it is "OMAXI4", "OMAXI4_Lite", "OMAHB", "OMAHB_Lite"? If so, LGTM, should run fine in docs. |
Maybe a naïve question, but why include both |
case (AXI4Protocol, AXI4SubProtocol) => "AXI Protocol" | ||
case (AXI4Protocol, AXI4LiteSubProtocol) => "AXI Lite Protocol" | ||
case (APBProtocol, APBSubProtocol) => "APB Protocol" | ||
case (TLProtocol, TL_UHSubProtocol) => "TileLink specification" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this called "specification" when the others are called "Protocol"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I haven't edited the description for TL, but I can update it - do you think mentioning UL, UH and CS will also be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related issue:
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
An example representation of a port with AXI protocol:
An example representation of a port with AHB-Lite protocol: