Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumping firrtl #2324

Merged
merged 1 commit into from
Mar 6, 2020
Merged

bumping firrtl #2324

merged 1 commit into from
Mar 6, 2020

Conversation

debs-sifive
Copy link
Contributor

@debs-sifive debs-sifive commented Mar 6, 2020 •
edited by jackkoenig
Loading

Summary of changes (all bug fixes in FIRRTL):

  • Do not duplicate modules when there is no reason to
  • Clarify spec for divide-by-zero and single-line when-else
  • Fix error message for negative width exception
  • Revert not inlining to fix Verilog emission bug

Related issue: chipsalliance/firrtl#1425

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

Updating FIRRTL to revert InlineNots

@debs-sifive debs-sifive requested review from azidar and jackkoenig March 6, 2020 20:47
jackkoenig
jackkoenig approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkoenig jackkoenig merged commit 96fe770 into master Mar 6, 2020
@jackkoenig jackkoenig deleted the bump-fir branch March 6, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

@azidar azidar Awaiting requested review from azidar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debs-sifive @jackkoenig