Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make LazyModule.nodes accessable by users. #2301

Merged
merged 1 commit into from
Mar 28, 2020
Merged

make LazyModule.nodes accessable by users. #2301

merged 1 commit into from
Mar 28, 2020

Conversation

sequencer
Copy link
Member

Type of change: other enhancement

Impact: API modification

Development Phase: implementation

Release Notes

  1. make LazyModule.nodes accessable to user for debugging and reuse Nodes.
  2. refactor childrenIterator to nodeIterator, add nodeIterator to access all children's BaseNode.

@sequencer
make LazyModule.nodes accessable by users.
8c5c53c 
1. make LazyModule.nodes accessable to user for debugging and reuse
   Nodes.
2. refactor childrenIterator to nodeIterator, add nodeIterator to access
   all children's BaseNode.
@terpstra
Copy link
Contributor

Why do we need this? It makes the API more porous.

@sequencer
Copy link
Member Author

Hello, @terpstra.
We(SiFive China) are experimentally using https://github.com/ucb-bar/chisel-testers2 to establish a TileLink unittest framework.
Thus beside extracting sub-LazyModule from Top LazyModule with getChildren API, we also need exporting nodes form these LazyModules to reconstruct interfaces in the tester2 side.

terpstra
terpstra approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@terpstra terpstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sequencer
Copy link
Member Author

Thank you!

@sequencer
Copy link
Member Author

any chance to get this merged?

@terpstra
Copy link
Contributor

Ah. Sorry about that. I thought you could merge it yourself after I approved it.

@terpstra terpstra merged commit 3997fce into chipsalliance:master Mar 28, 2020
@sequencer
Copy link
Member Author

Thank you! I don't have access to rc, so I can't merge it.

@sequencer sequencer deleted the diplomacy_nodes branch March 29, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terpstra terpstra terpstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sequencer @terpstra