Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert DM and JTAG to chisel3 #2203

Merged
merged 5 commits into from
Nov 22, 2019
Merged

Convert DM and JTAG to chisel3 #2203

merged 5 commits into from
Nov 22, 2019

Conversation

ernie-sifive
Copy link
Contributor

Related issue:

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

This PR converts the Debug Module and JTAG unit to chisel3. This is to enable them to use the new Chisel3 reset functionality.

Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! A few questions about places it seems the functionality actually changed and whether that is intentional/desired.

Also not sure about the fixes in the JTAG where we had issues with chisel3 before.

Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved without testing

@ernie-sifive ernie-sifive merged commit 2a8432d into master Nov 22, 2019
@ernie-sifive ernie-sifive deleted the debug-chisel3 branch November 22, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants