This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Make EmittedAnnotation Unserializable #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
seldridge
added
bugfix
Please Merge
jackkoenig
approved these changes
Jan 6, 2020
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2020
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9e1c224)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Jan 6, 2020
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9e1c224) Co-authored-by: Schuyler Eldridge <schuyler.eldridge@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This large annotation is causing problems with ChiselStage serialization.
Chisel3 adds an
EmittedFirrtlCircuitAnnotationdue to the needs to maintain backwards compatibility withChiselExecutionResult. This large annotation then winds up being serialized to JSON and causing the heap to blow up.This fixes that problem by preventing this from getting serialized.
This was never a problem for FIRRTL as FIRRTL has an emitter that runs and removes this annotation.
Checklist
Type of Improvement
API Impact
None.
Backend Code Generation Impact
None.
Desired Merge Strategy