Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow BoringUtils to use existing port in a closed module #4484

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Allow BoringUtils to use existing port in a closed module #4484

merged 2 commits into from
Oct 25, 2024

Conversation

tmckay-sifive
Copy link
Contributor

@tmckay-sifive tmckay-sifive commented Oct 23, 2024 •
edited by mwachs5
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

When trying to drill a port, it doesn't matter if the module is closed. We do not need to construct new hardware and can just use the existing port.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@tmckay-sifive
Copy link
Contributor Author

Will add a test shortly.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Oct 24, 2024
@mwachs5 mwachs5 modified the milestones: 3.6.x, 6.x Oct 24, 2024
@mwachs5 mwachs5 merged commit 9d58f0d into chipsalliance:main Oct 25, 2024
15 checks passed
@mergify mergify bot added the Backported This PR has been backported label Oct 25, 2024
mergify bot pushed a commit that referenced this pull request Oct 25, 2024
@tmckay-sifive @mergify
Allow BoringUtils to use existing port in a closed module (#4484)
7fcd314 
* fix case ordering when drilling connection

* add test

(cherry picked from commit 9d58f0d)

# Conflicts:
#	src/main/scala/chisel3/util/experimental/BoringUtils.scala
@mergify mergify bot mentioned this pull request Oct 25, 2024
Merged
14 tasks
jackkoenig pushed a commit that referenced this pull request Nov 26, 2024
@tmckay-sifive @jackkoenig
Allow BoringUtils to use existing port in a closed module (#4484)
ae7da43 
* fix case ordering when drilling connection

* add test

(cherry picked from commit 9d58f0d)
chiselbot pushed a commit that referenced this pull request Nov 26, 2024
@mergify @tmckay-sifive
Allow BoringUtils to use existing port in a closed module (#4484) (#4486
a5df567 
)

* fix case ordering when drilling connection

* add test

(cherry picked from commit 9d58f0d)

Co-authored-by: Trevor McKay <trevor.mckay@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@tmckay-sifive @mwachs5 @jackkoenig