Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Lookupable for HasTarget (used by SRAM) (backport #4481) #4482

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 18, 2024

I also changed HasTarget to only wrap SramTarget rather than any NamedComponent which I explain in the comments:

This is only currently used for SRAM to hide the underlying Memory but still let users annotate it.
Rather than generalizing this, it's more likely that we'll just delete it (and the use in SRAM) in favor of Path Properties.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4481 done by [Mergify](https://mergify.com).

@mergify mergify bot added the Backport Automated backport, please consider for minor release label Oct 18, 2024
@github-actions github-actions bot added the Feature New feature, will be included in release notes label Oct 18, 2024
@jackkoenig jackkoenig force-pushed the mergify/bp/6.x/pr-4481 branch from 9dc3f4e to 3384d28 Compare November 26, 2024 01:01
@chiselbot chiselbot merged commit 648366a into 6.x Nov 26, 2024
15 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4481 branch November 26, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants