Specialize Index for literal indices with LitIndex #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
added
the
Performance
azidar
approved these changes
Jul 11, 2024
This saves 16-bytes per Vec element.
jackkoenig
force-pushed
the
jackkoenig/specialize-index-ir
branch
from
e4f121e
to
50b5e9d
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
This saves 16-bytes per Vec element. (cherry picked from commit c107e31) # Conflicts: # core/src/main/scala/chisel3/experimental/hierarchy/core/Lookupable.scala # src/main/scala/chisel3/aop/Select.scala # src/main/scala/chisel3/util/SRAM.scala
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
Jul 11, 2024
…4274) * Specialize Index for literal indices with LitIndex (#4268) This saves 16-bytes per Vec element. (cherry picked from commit c107e31) # Conflicts: # core/src/main/scala/chisel3/experimental/hierarchy/core/Lookupable.scala # src/main/scala/chisel3/aop/Select.scala # src/main/scala/chisel3/util/SRAM.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <koenig@sifive.com>
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #4259 (so this should be merged after it)
The benefit comes from not boxing static indices in ILits (and BigInts although those are memoized). Each ILit is 16-bytes, not to mention at least 2 memory loads to get the index when using it.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
This saves 16-bytes per Vec element.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.