Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChiselStage.emitCHIRRTLFile #4232

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Add ChiselStage.emitCHIRRTLFile #4232

merged 1 commit into from
Jul 1, 2024

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

Emits a file without returning the serialized object which is more memory efficient and supports > 2 GiB of serialized FIRRTL text.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig
Add ChiselStage.emitCHIRRTLFile
93b3a1a 
Emits a file without returning the serialized object which is more
memory efficient and supports > 2 GiB of serialized FIRRTL text.
@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Jul 1, 2024
@jackkoenig jackkoenig added this to the 3.6.x milestone Jul 1, 2024
seldridge
seldridge approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkoenig jackkoenig merged commit e8edc8f into main Jul 1, 2024
18 checks passed
@jackkoenig jackkoenig deleted the emitchirrtlfile branch July 1, 2024 21:41
@mergify mergify bot added the Backported This PR has been backported label Jul 1, 2024
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
@jackkoenig @mergify
Add ChiselStage.emitCHIRRTLFile (#4232)
ee7bbea 
Emits a file without returning the serialized object which is more
memory efficient and supports > 2 GiB of serialized FIRRTL text.

(cherry picked from commit e8edc8f)
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
@jackkoenig @mergify
Add ChiselStage.emitCHIRRTLFile (#4232)
7858d09 
Emits a file without returning the serialized object which is more
memory efficient and supports > 2 GiB of serialized FIRRTL text.

(cherry picked from commit e8edc8f)
This was referenced Jul 1, 2024
Merged
Merged
chiselbot pushed a commit that referenced this pull request Jul 1, 2024
@mergify @jackkoenig
Add ChiselStage.emitCHIRRTLFile (#4232) (#4233)
bad5ac1 
Emits a file without returning the serialized object which is more
memory efficient and supports > 2 GiB of serialized FIRRTL text.

(cherry picked from commit e8edc8f)

Co-authored-by: Jack Koenig <koenig@sifive.com>
jackkoenig added a commit that referenced this pull request Jul 1, 2024
@mergify @jackkoenig
Add ChiselStage.emitCHIRRTLFile (#4232) (#4234)
e3f8e0b 
Emits a file without returning the serialized object which is more
memory efficient and supports > 2 GiB of serialized FIRRTL text.

(cherry picked from commit e8edc8f)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge