add test for FlatIO port ordering #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwachs5
added
the
Internal
mwachs5
commented
May 30, 2024
mwachs5
commented
May 30, 2024
jackkoenig
reviewed
May 30, 2024
Comment on lines
+95
to
+102
| matchesAndOmits( | ||
| ChiselStage.emitSystemVerilog(new MyModule) | ||
| )("io_foo,")("io_bar,") | ||
|
|
||
| matchesAndOmits( | ||
| ChiselStage.emitSystemVerilog(new MyFlatIOModule) | ||
| )("foo,")("bar,") | ||
| } |
There was a problem hiding this comment.
Clever, I need to just finish and merge #3410 as that would be a good way to test this.
I wonder if we should also check Vec and also check recursive order...
jackkoenig
approved these changes
May 30, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit c3c9979) # Conflicts: # src/test/scala/chiselTests/experimental/FlatIOSpec.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit c3c9979)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
May 30, 2024
* Add test for FlatIO port ordering (#4113) (cherry picked from commit c3c9979) # Conflicts: # src/test/scala/chiselTests/experimental/FlatIOSpec.scala * Added MatchesOrOmits * Resolve backport conflicts --------- Co-authored-by: Megan Wachs <megan@sifive.com> Co-authored-by: Adam Izraelevitz <azidar@gmail.com> Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot
pushed a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a unit test. I thought going into writing the test that FlatIO maybe was not working as we intended, but i think it is just general misunderstanding of how Record and Bundle treat their elements.
This might be more of a test of CIRCT's lowering ABI, but firtool internally considers the port order part of the contract (not just the name of the signals), so check that we are doing what is sane here.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Added a unit test for FlatIO Ordering being maintained
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.