Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boring tap of non-passive source from parent. (backport #4083) #4096

Merged
merged 4 commits into from
May 27, 2024

Commits on May 24, 2024

  1. Fix boring tap of non-passive source from parent. (#4083)

    Expected result is fully aligned, which is what happens
    when reading from a probe.
    
    When the source is already at the LCA (from parent)
    there's no probe and the secret connections only support
    a few commands.
    
    For lack of a way to do, e.g., `:#=` here,
    use `read(probe(x))` to get the fully aligned result
    that's expected and bored down to the child.
    
    This isn't ideal but fixes this using only the sorts of expressions
    and commands that we've already committed to supporting.
    
    Fixes #3557.
    
    (cherry picked from commit 0dbedc3)
    
    # Conflicts:
    #	core/src/main/scala/chisel3/RawModule.scala
    dtzSiFive authored and jackkoenig committed May 24, 2024
    Configuration menu
    Copy the full SHA
    afd7bfc View commit details
    Browse the repository at this point in the history
  2. Resolve backport conflicts

    jackkoenig committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9f8287a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e25a865 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    16dc62e View commit details
    Browse the repository at this point in the history