Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix widths for literal values in Bundle literals (backport #4082) #4090

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix widths for literal values in Bundle literals (backport #4082) #4090

merged 2 commits into from
May 24, 2024

Commits on May 23, 2024

  1. Fix widths for literal values in Bundle literals (#4082) 

    * Fix widths for literal values in Bundle literals

Previously, the user-specified (or unspecified minimum width) of the
literal would be used in some operations like concatenation.

* Implicitly truncate too-wide literals in Bundle literals

This is to fix a bug in concatenation without breaking things relying on
implicit truncation. This will be a warning in newer versions of Chisel.

(cherry picked from commit 3939e57)

# Conflicts:
#	core/src/main/scala/chisel3/internal/firrtl/IR.scala
#	src/test/scala/chiselTests/BundleLiteralSpec.scala
#	src/test/scala/chiselTests/ConnectableSpec.scala
#	src/test/scala/chiselTests/VecLiteralSpec.scala
    @jackkoenig @mergify
    jackkoenig authored and mergify[bot] committed May 23, 2024
    Configuration menu
    Copy the full SHA
    976dc81 View commit details
    Browse the repository at this point in the history

  2. Resolve backport conflicts and waive false MiMa failure.

    @jackkoenig
    jackkoenig committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c054104 View commit details
    Browse the repository at this point in the history