Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataMirrorSpec.scala #4039

Merged
merged 1 commit into from
May 1, 2024
Merged

Update DataMirrorSpec.scala #4039

merged 1 commit into from
May 1, 2024

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented May 1, 2024

Tiny cleanup of the test once the name of the function changed

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Minor fixup to the test added in #4036

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Tiny cleanup of the test once the name of the function changed
@mwachs5 mwachs5 added the Internal Internal change, does not affect users, will be included in release notes label May 1, 2024
@mwachs5 mwachs5 added this to the 7.0 milestone May 1, 2024
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was about to send this.

@jackkoenig jackkoenig added No Release Notes Exclude from release notes, consider using Internal instead and removed Internal Internal change, does not affect users, will be included in release notes labels May 1, 2024
@jackkoenig jackkoenig merged commit 13e33ac into main May 1, 2024
20 checks passed
@jackkoenig jackkoenig deleted the mwachs5-patch-4 branch May 1, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants