Add a new BoringUtils.drive API for boring to drive a sink. #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
mikeurbach
force-pushed
the
mikeurbach/boring-drive-api
branch
from
aa22f99
to
7a5c251
Compare
|
What I have here is the simplest change to the private boreOrTap implementation to be able to bore "into" something rather than "out of" something. I think it's working for my use case and shouldn't be breaking any existing uses, but the implementation is getting a little convoluted. E.g., the |
dtzSiFive
reviewed
Apr 2, 2024
SpriteOvO
added a commit
that referenced
this pull request
Apr 6, 2024
* Specify right convention for modules * Specify `desiredName` as `defname` for `extmodule` Removed FixedPoint in muxes-and-input-selection.md (#3956) Make SRAMs directly emit FIRRTL memories (#3955) Add a new BoringUtils.drive API for boring to drive a sink. (#3960) This API allows users to bore to a sink they plan to drive, which complements the existing API to bore from a source to read. Support literals in DataView (#3964) Add requireIsAnnotatable for better errors when annotating literals (#3968)
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 8, 2024
This API allows users to bore to a sink they plan to drive, which complements the existing API to bore from a source to read.
mikeurbach
added a commit
that referenced
this pull request
Apr 15, 2024
This follows up on #3960 to address the behavior at the final module for the sink being driven. We already have special handling for boring out from the original source, and we need the inverse here. When we reach the final sink, if it is an input port, we should return it, rather than boring into the module and connecting to it.
14 tasks
mikeurbach
added a commit
that referenced
this pull request
Apr 15, 2024
…3998) This follows up on #3960 to address the behavior at the final module for the sink being driven. We already have special handling for boring out from the original source, and we need the inverse here. When we reach the final sink, if it is an input port, we should use it, rather than boring into the module and connecting to it.
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 20, 2024
This API allows users to bore to a sink they plan to drive, which complements the existing API to bore from a source to read.
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 20, 2024
This API allows users to bore to a sink they plan to drive, which complements the existing API to bore from a source to read.
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 20, 2024
…3998) This follows up on #3960 to address the behavior at the final module for the sink being driven. We already have special handling for boring out from the original source, and we need the inverse here. When we reach the final sink, if it is an input port, we should use it, rather than boring into the module and connecting to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
This API allows users to bore to a sink they plan to drive, which complements the existing API to bore from a source to read.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.